Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatkcnvcaller #362

Merged
merged 48 commits into from
Jul 7, 2023
Merged

Conversation

ramprasadn
Copy link
Collaborator

@ramprasadn ramprasadn commented Jun 7, 2023

PR checklist

This PR adds GATK's germline CNV calling workflow to the pipeline, and includes relevant changes in the documentation.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 007c5ee

+| ✅ 154 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-07 12:19:58

@ramprasadn ramprasadn marked this pull request as ready for review July 5, 2023 19:03
@ramprasadn ramprasadn added this to the Release candidate 2 milestone Jul 5, 2023
@ramprasadn ramprasadn linked an issue Jul 5, 2023 that may be closed by this pull request
Copy link
Collaborator

@jemten jemten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and well written!

}

withName: '.*PREPARE_REFERENCES:GATK_PREPROCESS_WES' {
ext.args = { "--bin-length 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ext.args = { "--bin-length 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }
ext.args = { "--bin-length 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }

@@ -117,4 +117,15 @@ process {
enabled: false
]
}

withName: '.*PREPARE_REFERENCES:GATK_PREPROCESS_WGS' {
ext.args = { "--padding 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ext.args = { "--padding 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }
ext.args = { "--padding 0 --interval-merging-rule OVERLAPPING_ONLY --exclude-intervals ${params.mito_name}" }

docs/output.md Outdated
Comment on lines 13 to 14
#### GATK GermlineCNVCaller (CNV calling)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### GATK GermlineCNVCaller (CNV calling)

@@ -0,0 +1,81 @@
#!/usr/bin/env nextflow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the new standard to add a shebang for nextflow subworkflows? We should add it to the subworkflows as well then (another PR).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.. removed it.

GATK4_COLLECTREADCOUNTS ( input, ch_fasta, ch_fai, ch_genome_dictionary )

GATK4_COLLECTREADCOUNTS.out.tsv
.groupTuple()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add size here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its actually not necessary here.. I have removed it now.

@ramprasadn ramprasadn merged commit 06a9317 into nf-core:dev Jul 7, 2023
@ramprasadn ramprasadn mentioned this pull request Jul 7, 2023
@jemten jemten deleted the gatkcnvcaller branch July 7, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GATKs CNVcaller
3 participants